summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2009-06-13 21:41:57 (GMT)
committer Denys Vlasenko <vda.linux@googlemail.com>2009-06-13 21:41:57 (GMT)
commit2441060bebec2d65c9d106335223f37ec6e8ea5b (patch)
tree22c62604f5bbde2defb5a69400fb7d27bf847dc7
parent16635cc2e052897ce7c2d4989acd0b706c3ac3dd (diff)
downloadbusybox-2441060bebec2d65c9d106335223f37ec6e8ea5b.tar.gz
busybox-2441060bebec2d65c9d106335223f37ec6e8ea5b.tar.bz2
fix or document testsuite failures
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rwxr-xr-xtestsuite/mdev.tests2
-rwxr-xr-xtestsuite/printf.tests13
-rwxr-xr-xtestsuite/seq.tests3
3 files changed, 11 insertions, 7 deletions
diff --git a/testsuite/mdev.tests b/testsuite/mdev.tests
index 6d6a21d..a175007 100755
--- a/testsuite/mdev.tests
+++ b/testsuite/mdev.tests
@@ -152,7 +152,7 @@ brw-r--r-- 1 0 0 sda
# continuing to use directory structure from prev test
rm -rf mdev.testdir/dev/*
-echo "@8,0 :1 644" >mdev.testdir/etc/mdev.conf
+echo "@8,0 0:1 644" >mdev.testdir/etc/mdev.conf
testing "mdev #maj,min and no explicit uid" \
"env - PATH=$PATH ACTION=add DEVPATH=/block/sda chroot mdev.testdir /mdev 2>&1;
ls -lnR mdev.testdir/dev | $FILTER_LS" \
diff --git a/testsuite/printf.tests b/testsuite/printf.tests
index f9d1dec..558ecb1 100755
--- a/testsuite/printf.tests
+++ b/testsuite/printf.tests
@@ -79,12 +79,13 @@ testing "printf understands %Ld" \
"-5\n""0\n" \
"" ""
-# We are "more correct" here than bash/coreutils: they happily print -2
-# as if it is a huge unsigned number
-testing "printf handles %u -N" \
- "${bb}printf '%u\n' 1 -2 3 2>&1; echo \$?" \
- "1\n""printf: -2: invalid number\n""0\n""3\n""0\n" \
- "" ""
+# "FIXED" now to act compatibly
+## We are "more correct" here than bash/coreutils: they happily print -2
+## as if it is a huge unsigned number
+#testing "printf handles %u -N" \
+# "${bb}printf '%u\n' 1 -2 3 2>&1; echo \$?" \
+# "1\n""printf: -2: invalid number\n""0\n""3\n""0\n" \
+# "" ""
# Actually, we are wrong here: exit code should be 1
testing "printf handles %d bad_input" \
diff --git a/testsuite/seq.tests b/testsuite/seq.tests
index cea4eef..4e43d0e 100755
--- a/testsuite/seq.tests
+++ b/testsuite/seq.tests
@@ -29,6 +29,8 @@ testing "seq count up by 2" "seq 4 2 8" "4\n6\n8\n" "" ""
testing "seq count down by 2" "seq 8 -2 4" "8\n6\n4\n" "" ""
testing "seq count wrong way #1" "seq 4 -2 8" "" "" ""
testing "seq count wrong way #2" "seq 8 2 4" "" "" ""
+# Fails: first item is printed as 3, not 3.0
+# note: makes sense to fix "seq 3 .30 4" case as well
testing "seq count by .3" "seq 3 .3 4" "3.0\n3.3\n3.6\n3.9\n" "" ""
testing "seq count by -.9" "seq .7 -.9 -2.2" "0.7\n-0.2\n-1.1\n-2\n" "" ""
testing "seq count by zero" "seq 4 0 8 | head -n 10" "" "" ""
@@ -36,6 +38,7 @@ testing "seq count by zero" "seq 4 0 8 | head -n 10" "" "" ""
testing "seq one argument with padding" "seq -w 003" "001\n002\n003\n" "" ""
testing "seq two arguments with padding" "seq -w 005 7" "005\n006\n007\n" "" ""
testing "seq count down by 3 with padding" "seq -w 8 -3 04" "08\n05\n" "" ""
+# Known to fail
testing "seq count by .3 with padding" "seq -w 03 .3 0004" "003.0\n003.3\n003.6\n003.9\n" "" ""
exit $FAILCOUNT