summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2010-06-18 00:12:56 (GMT)
committer Denys Vlasenko <vda.linux@googlemail.com>2010-06-18 00:12:56 (GMT)
commit3b727ccb70d288b30d3af5d7964e703bc47b33fb (patch)
tree413540d0264cecffcc6a6a306953c910958118b5
parentd86b4c3907a78ab8785bcd6342ca233d0fe23ed0 (diff)
downloadbusybox-3b727ccb70d288b30d3af5d7964e703bc47b33fb.tar.gz
busybox-3b727ccb70d288b30d3af5d7964e703bc47b33fb.tar.bz2
add a comment about sed and suid bits
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--editors/sed.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/editors/sed.c b/editors/sed.c
index a5ef400..28f0c73 100644
--- a/editors/sed.c
+++ b/editors/sed.c
@@ -1365,6 +1365,8 @@ int sed_main(int argc UNUSED_PARAM, char **argv)
/* Set permissions/owner of output file */
fstat(fileno(file), &statbuf);
+ /* chmod'ing AFTER chown would preserve suid/sgid bits,
+ * but GNU sed 4.2.1 does not preserve them either */
fchmod(nonstdoutfd, statbuf.st_mode);
fchown(nonstdoutfd, statbuf.st_uid, statbuf.st_gid);
add_input_file(file);