summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2011-04-16 17:31:08 (GMT)
committer Denys Vlasenko <vda.linux@googlemail.com>2011-04-16 17:31:08 (GMT)
commitd506897b4ef94a85013696d543686162293a02f1 (patch)
treeeea4485c972188a7740f668a929a4e3cb5c3f3f7
parent43a3d50e14902e746ee53b7cfb63fe190bd5387f (diff)
downloadbusybox-d506897b4ef94a85013696d543686162293a02f1.tar.gz
busybox-d506897b4ef94a85013696d543686162293a02f1.tar.bz2
wget: add a note about bug 3625
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--networking/wget.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/networking/wget.c b/networking/wget.c
index 3a4be98..df6d363 100644
--- a/networking/wget.c
+++ b/networking/wget.c
@@ -661,6 +661,12 @@ static void download_one_url(const char *url)
#if ENABLE_FEATURE_WGET_AUTHENTICATION
if (target.user) {
+//TODO: URL-decode "user:password" string before base64-encoding:
+//wget http://test:my%20pass@example.com should send
+// Authorization: Basic dGVzdDpteSBwYXNz
+//which decodes to "test:my pass", instead of what we send now:
+// Authorization: Basic dGVzdDpteSUyMHBhc3M=
+//Can reuse decodeString() from httpd.c
fprintf(sfp, "Proxy-Authorization: Basic %s\r\n"+6,
base64enc(target.user));
}