aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Heiko Thiery <heiko.thiery@gmail.com>2020-05-27 09:11:13 +0200
committerGravatar Yann E. MORIN <yann.morin.1998@free.fr>2020-05-31 10:27:01 +0200
commit1a14a838eaa88ae683bf8c0cb0ae6cc7e1d10d49 (patch)
tree423468305dda64120d1ef0a0b58ffe9d7c7ccf3d
parentae417368f52518735dfce6c83d8e064298e6d0dd (diff)
downloadbuildroot-1a14a838eaa88ae683bf8c0cb0ae6cc7e1d10d49.tar.gz
buildroot-1a14a838eaa88ae683bf8c0cb0ae6cc7e1d10d49.tar.bz2
package/sysrepo: fix SysV init script
The current script (S51sysrepo-plugind) is not able to stop the daemon. Possible options to fix the problem: A) By adding the "-m -p $PIDFILE" option to start the pid file will be created but it will not contain the correct PID used by the daemon. This is obviously because the daemon forks. B) By not starting the daemon in background (sysrepo-plugind -d) and let do it by start-stop-daemon with "-b" option. But then the log messages of the daemon will not longer ends in the syslog but to stderr. C) Start the daemon without a pidfile and stop the daemon with the "-x" option. The only valid option is C to fix that. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> [yann.morin.1998@free.fr: introduce EXECUTABLE] Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
-rw-r--r--package/sysrepo/S51sysrepo-plugind6
1 files changed, 3 insertions, 3 deletions
diff --git a/package/sysrepo/S51sysrepo-plugind b/package/sysrepo/S51sysrepo-plugind
index 74b68396bf..60ea3ba7a9 100644
--- a/package/sysrepo/S51sysrepo-plugind
+++ b/package/sysrepo/S51sysrepo-plugind
@@ -1,7 +1,7 @@
#!/bin/sh
DAEMON="sysrepo-plugind"
-PIDFILE="/var/run/$DAEMON.pid"
+EXECUTABLE="/usr/bin/$DAEMON"
SYSREPO_PLUGIND_ARGS=""
@@ -10,7 +10,7 @@ SYSREPO_PLUGIND_ARGS=""
start() {
printf 'Starting %s: ' "$DAEMON"
- start-stop-daemon -S -q -x "/usr/bin/$DAEMON" \
+ start-stop-daemon -S -q -x "$EXECUTABLE" \
-- $SYSREPO_PLUGIND_ARGS
status=$?
if [ "$status" -eq 0 ]; then
@@ -23,7 +23,7 @@ start() {
stop() {
printf 'Stopping %s: ' "$DAEMON"
- start-stop-daemon -K -q -p $PIDFILE
+ start-stop-daemon -K -q -x "$EXECUTABLE"
status=$?
if [ "$status" -eq 0 ]; then
echo "OK"