diff options
authorGravatar Ricardo Martincoski <ricardo.martincoski@gmail.com>2017-12-02 02:28:24 -0200
committerGravatar Thomas Petazzoni <thomas.petazzoni@free-electrons.com>2017-12-02 14:51:27 +0100
commit29d9f2f01445bb2e2f8a1cab293be4d62d34f2b0 (patch)
parent2f6e5467f61a4339acd5433707df9a33739c1792 (diff)
check-package: avoid false warning of useless flag
Just AUTORECONF = NO is redundant. Just HOST_AUTORECONF = NO is redundant. But the combination of AUTORECONF = YES + HOST_AUTORECONF = NO is valid. So basically for all variables that have inheritance between target and host, having the host variant of the variable set the variable value back to its default is correct if the target variable is set. Instead of increasing complexity of the script to fully detect this case, ignore the host flag set to its default value as it can be overriding a non-default value inherited from the equivalent target flag. Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Yann E. MORIN <yann.morin.1998@free.fr> Reported-by: Yann E. MORIN <yann.morin.1998@free.fr> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py
index 6ed6011921..817e80923e 100644
--- a/utils/checkpackagelib/lib_mk.py
+++ b/utils/checkpackagelib/lib_mk.py
@@ -216,7 +216,7 @@ class UselessFlag(_CheckFunction):
.format(self.filename, lineno, self.url_to_manual),
- if self.DEFAULT_AUTOTOOLS_FLAG.search(text):
+ if self.DEFAULT_AUTOTOOLS_FLAG.search(text) and not text.lstrip().startswith("HOST_"):
return ["{}:{}: useless default value "
.format(self.filename, lineno, self.url_to_manual),