aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar John Keeping <john@metanate.com>2018-05-01 13:28:41 +0100
committerGravatar Thomas Petazzoni <thomas.petazzoni@bootlin.com>2018-05-01 15:21:56 +0200
commitd3dca1e9936bcaa0eed226a5bcb8c6a4d1fd1472 (patch)
treed4416fde455faec8024d58fff23b687184701a52
parent5b5fb4427e6e182635cb849afa0ca1a16facd302 (diff)
downloadbuildroot-d3dca1e9936bcaa0eed226a5bcb8c6a4d1fd1472.tar.gz
buildroot-d3dca1e9936bcaa0eed226a5bcb8c6a4d1fd1472.tar.bz2
core/pkg-generic: only save latest package list
When rebuilding a package, simply appending the package's file list to the global list means that the package list grows for every rebuild, as does the time taken to check for files installed by multiple packages. Furthermore, we get false positives where a file is reported as being installed by multiple copies of the same package. With this approach we may end up with orphaned files in the target filesystem if a package that has been updated and rebuilt no longer installs the same set of files, but we know that only a clean build will produce reliable results. In fact it may be helpful to identify these orphaned files as evidence that the build is not clean. Signed-off-by: John Keeping <john@metanate.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
-rw-r--r--package/pkg-generic.mk2
1 files changed, 2 insertions, 0 deletions
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index bd47ca1964..87c856407d 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -63,6 +63,8 @@ GLOBAL_INSTRUMENTATION_HOOKS += step_time
# $(2): base directory to search in
# $(3): suffix of file (optional)
define step_pkg_size_inner
+ @touch $(BUILD_DIR)/packages-file-list$(3).txt
+ $(SED) '/^$(1),/d' $(BUILD_DIR)/packages-file-list$(3).txt
cd $(2); \
find . \( -type f -o -type l \) \
-newer $($(PKG)_DIR)/.stamp_built \