path: root/DEVELOPERS
diff options
authorGravatar Robert Beckett <bbeckett@netvu.org.uk>2018-06-04 14:32:30 +0100
committerGravatar Thomas Petazzoni <thomas.petazzoni@bootlin.com>2018-06-04 21:59:55 +0200
commita5ba72946ebf597a163bae9b12453dfa68993d54 (patch)
tree9fa8866ea589152be751b53b75edcd61107bc38b /DEVELOPERS
parent1f47aa89f9fc3d4a8f59c4890a1174c6db1e222b (diff)
dl-wrapper: Fix support for URIs containing '+'
'+' is a valid character in a url. The current dl-wrapper gets the URI scheme by dropping everything after the last '+' character, with the intension of finding 'git' from e.g. 'git+https://uri'. If a uri has a '+' anywhere in it, it ends up using too much of the string as a scheme, and fails to match the handler properly. An example of where this form of URI is used is when using deploy tokens in gitlab. It uses a form like https://<username>:<password>@gitlab.com/<group>/<repo.git> where username for deploy token is of the form 'gitlab+deploy-token-<number>'. Use the %% operator to search backwards until the last '+' character when dropping the rest of the string as we know that the first '+' in the string should be the scheme. Signed-off-by: Robert Beckett <bbeckett@netvu.org.uk> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Diffstat (limited to 'DEVELOPERS')
0 files changed, 0 insertions, 0 deletions