path: root/linux/linux.mk
diff options
authorGravatar Yann E. MORIN <yann.morin.1998@free.fr>2017-11-12 18:45:41 +0100
committerGravatar Thomas Petazzoni <thomas.petazzoni@free-electrons.com>2017-11-30 11:49:07 +0100
commitcef77a6cf5c1982d22e899f046d5e345c0271e7a (patch)
treeb8637d2c18bba05e42b795e3f09341d6904b4e8a /linux/linux.mk
parent6426f64176ea33660a05c8bccd2b8c5e38220a63 (diff)
linux: meddle not in the internals of filesystems
Currently, the rule to rebuild the Linux kernel with an initramfs directly depends on the path of the file of the intermediate cpio image. This is inherently "bad" from a purity point of view; linux.mk should not have to delve into the fs internals. Rather, make it directly depend on the "frontal" rule that generates the cpio image. Drop the comment for linux-rebuild-with-initramfs, it was misleading (talking about generating "the initramfs list of files", which is not what was done, since we use a cpio as source of initramfs, not a list of files). Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Romain Naour <romain.naour@openwide.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'linux/linux.mk')
1 files changed, 7 insertions, 11 deletions
diff --git a/linux/linux.mk b/linux/linux.mk
index 1c5631f937..5300b9cfc5 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -484,21 +484,17 @@ endif # BR_BUILDING
$(eval $(kconfig-package))
# Support for rebuilding the kernel after the cpio archive has
-# been generated in $(BINARIES_DIR)/rootfs.cpio.
-$(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed
-$(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_images_installed
-$(LINUX_DIR)/.stamp_initramfs_rebuilt: $(BINARIES_DIR)/rootfs.cpio
+# been generated.
+.PHONY: linux-rebuild-with-initramfs
+linux-rebuild-with-initramfs: $(LINUX_DIR)/.stamp_target_installed
+linux-rebuild-with-initramfs: $(LINUX_DIR)/.stamp_images_installed
+linux-rebuild-with-initramfs: rootfs-cpio
@$(call MESSAGE,"Rebuilding kernel with initramfs")
# Build the kernel.
# Copy the kernel image(s) to its(their) final destination
# If there is a .ub file copy it to the final destination
- $(Q)touch $@
-# The initramfs building code must make sure this target gets called
-# after it generated the initramfs list of files.
-linux-rebuild-with-initramfs: $(LINUX_DIR)/.stamp_initramfs_rebuilt