aboutsummaryrefslogtreecommitdiff
path: root/package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch
diff options
context:
space:
mode:
authorGravatar Gustavo Zacarias <gustavo@zacarias.com.ar>2011-03-10 09:25:04 -0300
committerGravatar Peter Korsgaard <jacmet@sunsite.dk>2011-03-10 14:39:57 +0100
commiteb2ebf949007b8a608d0624c764a67a2fbcb9fd6 (patch)
tree918a2c643c8b6a552ca41a62373e5c32b8f3f2f5 /package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch
parent6f7187d11d6246539f2c98f40f6df5556e513f1d (diff)
downloadbuildroot-eb2ebf949007b8a608d0624c764a67a2fbcb9fd6.tar.gz
buildroot-eb2ebf949007b8a608d0624c764a67a2fbcb9fd6.tar.bz2
busybox 1.18.3: add patches for klogd and menuconfig
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Diffstat (limited to 'package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch')
-rw-r--r--package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch45
1 files changed, 45 insertions, 0 deletions
diff --git a/package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch b/package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch
new file mode 100644
index 0000000000..2272cd0030
--- /dev/null
+++ b/package/busybox/busybox-1.18.3/busybox-1.18.3-klogd.patch
@@ -0,0 +1,45 @@
+--- busybox-1.18.3/sysklogd/klogd.c
++++ busybox-1.18.3-klogd/sysklogd/klogd.c
+@@ -150,12 +150,41 @@ int klogd_main(int argc UNUSED_PARAM, ch
+ */
+ klogd_open();
+ openlog("kernel", 0, LOG_KERN);
++ /*
++ * glibc problem: for some reason, glibc changes LOG_KERN to LOG_USER
++ * above. The logic behind this is that standard
++ * http://pubs.opengroup.org/onlinepubs/9699919799/functions/syslog.html
++ * says the following about openlog and syslog:
++ * "LOG_USER
++ * Messages generated by arbitrary processes.
++ * This is the default facility identifier if none is specified."
++ *
++ * I believe glibc misinterpreted this text as "if openlog's
++ * third parameter is 0 (=LOG_KERN), treat it as LOG_USER".
++ * Whereas it was meant to say "if *syslog* is called with facility
++ * 0 in its 1st parameter without prior call to openlog, then perform
++ * implicit openlog(LOG_USER)".
++ *
++ * As a result of this, eh, feature, standard klogd was forced
++ * to open-code its own openlog and syslog implementation (!).
++ *
++ * Note that prohibiting openlog(LOG_KERN) on libc level does not
++ * add any security: any process can open a socket to "/dev/log"
++ * and write a string "<0>Voila, a LOG_KERN + LOG_EMERG message"
++ *
++ * Google code search tells me there is no widespread use of
++ * openlog("foo", 0, 0), thus fixing glibc won't break userspace.
++ *
++ * The bug against glibc was filed:
++ * bugzilla.redhat.com/show_bug.cgi?id=547000
++ */
+
+ if (i)
+ klogd_setloglevel(i);
+
+- bb_signals(BB_FATAL_SIGS, record_signo);
+ signal(SIGHUP, SIG_IGN);
++ /* We want klogd_read to not be restarted, thus _norestart: */
++ bb_signals_recursive_norestart(BB_FATAL_SIGS, record_signo);
+
+ syslog(LOG_NOTICE, "klogd started: %s", bb_banner);
+