path: root/package/flex/Config.in
diff options
authorGravatar Thomas De Schampheleire <patrickdepinguin@gmail.com>2013-11-07 09:24:37 +0100
committerGravatar Peter Korsgaard <peter@korsgaard.com>2013-11-10 23:59:57 +0100
commitbe084204eb418243d287f16b80290e564411c507 (patch)
treed0d78e130e4982ba90987e7bd1889701fc978dfc /package/flex/Config.in
parent3c33c11386240444c6fde0984f43c64f98ce516d (diff)
Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (untested) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Diffstat (limited to 'package/flex/Config.in')
1 files changed, 5 insertions, 1 deletions
diff --git a/package/flex/Config.in b/package/flex/Config.in
index be6140bd1e..52f7fe77f0 100644
--- a/package/flex/Config.in
+++ b/package/flex/Config.in
@@ -7,11 +7,12 @@ config BR2_PACKAGE_FLEX
bool "Install tool in the target"
# needs fork()
depends on BR2_USE_MMU
- depends on BR2_PACKAGE_FLEX
# runtime dependency
select BR2_PACKAGE_M4
depends on BR2_USE_WCHAR # m4
@@ -19,4 +20,7 @@ config BR2_PACKAGE_FLEX_BINARY
Install the flex binary tool in the target filesystem.
comment "flex binary needs a toolchain w/ wchar"
+ depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR