aboutsummaryrefslogtreecommitdiff
path: root/package/libnspr
diff options
context:
space:
mode:
authorGravatar Thomas De Schampheleire <patrickdepinguin@gmail.com>2013-12-20 22:31:30 +0100
committerGravatar Thomas Petazzoni <thomas.petazzoni@free-electrons.com>2013-12-25 12:21:39 +0100
commit35eaed8d07bdc73a83990bc306fcdb08b2e70eaf (patch)
treefe38a982159d30eeadbc0a30462da1676bdd11b0 /package/libnspr
parent142a81d60533ef179300c44fd29aaefbfae62d3a (diff)
downloadbuildroot-35eaed8d07bdc73a83990bc306fcdb08b2e70eaf.tar.gz
buildroot-35eaed8d07bdc73a83990bc306fcdb08b2e70eaf.tar.bz2
Config.in files: use if/endif instead of 'depends on' for main symbol
In the Config.in file of package foo, it often happens that there are other symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense when foo itself is enabled. There are two ways to express this: with depends on BR2_PACKAGE_FOO in each extra symbol, or with if BR2_PACKAGE_FOO ... endif around the entire set of extra symbols. The if/endif approach avoids the repetition of 'depends on' statements on multiple symbols, so this is clearly preferred. But even when there is only one extra symbol, if/endif is a more logical choice: - it is future-proof for when extra symbols are added - it allows to have just one strategy instead of two (less confusion) This patch modifies the Config.in files accordingly. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/libnspr')
-rw-r--r--package/libnspr/Config.in6
1 files changed, 4 insertions, 2 deletions
diff --git a/package/libnspr/Config.in b/package/libnspr/Config.in
index 1d732873d7..416f1c9554 100644
--- a/package/libnspr/Config.in
+++ b/package/libnspr/Config.in
@@ -2,11 +2,12 @@ config BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
def_bool y
depends on !BR2_arc && !BR2_xtensa && !BR2_bfin
+if BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
+
config BR2_PACKAGE_LIBNSPR
bool "libnspr"
depends on BR2_LARGEFILE
depends on BR2_TOOLCHAIN_HAS_THREADS
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
help
NSPR is the Netscape Portable Runtime library which provides
a platform-neutral API for system level and libc like
@@ -16,5 +17,6 @@ config BR2_PACKAGE_LIBNSPR
http://www.mozilla.org/projects/nspr/
comment "libnspr needs a toolchain w/ largefile, threads"
- depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+
+endif