aboutsummaryrefslogtreecommitdiff
path: root/package/libsoup/Config.in
diff options
context:
space:
mode:
authorGravatar Bernd Kuhls <bernd.kuhls@t-online.de>2017-05-25 18:34:43 +0200
committerGravatar Thomas Petazzoni <thomas.petazzoni@free-electrons.com>2017-05-29 22:52:34 +0200
commit30ed9de2fd8a572ffce26f7a9c8187335c567668 (patch)
tree543c9a5bc7022f43bc72d7db30e7e2e9dea0b346 /package/libsoup/Config.in
parent557f8d649d9a959e810a3c92774020a434d567a8 (diff)
downloadbuildroot-30ed9de2fd8a572ffce26f7a9c8187335c567668.tar.gz
buildroot-30ed9de2fd8a572ffce26f7a9c8187335c567668.tar.bz2
package/gnutls: disable for static build
The gnutils code uses __attribute__((constructor)) and __attribute__((destructor)) to call constructor/desctructor when a shared library is loaded. Constructor/desctructor are not used when a static library is used (except when if -Wl,--whole-archive -lgnutls -Wno-whole-archive is used, not tested). Even if gnutls initialization (_gnutls_global_init()) may be called manually, the gnutls maintainer said it's not supported [1]. "Note that static linking applications with gnutls is not something supported. gnutls relies on library constructors and destructors which are not loaded when linking statically." Now the gnutls script warns about static linking [2]. So disable gnutls statically by adding "depends on !BR2_STATIC_LIBS" at Kconfig level and --disable-static in GNUTLS_CONF_OPTS. Fixes: [taskd] http://autobuild.buildroot.net/results/c2d/c2dd5c1c9dc87d2943c15e58ee56e67d7375368c [ffmpeg] http://autobuild.buildroot.net/results/892/8926d319d6d1cd1ee72239ad7d9ca869d2355628 [sngrep] http://autobuild.buildroot.net/results/f7f/f7fb42d3742f6f01000a0d181e0c785640284405 [1] https://gitlab.com/gnutls/gnutls/issues/203 [2] https://gitlab.com/gnutls/gnutls/commit/6b748886799f88ddee9721dba4fc4d52854832ae Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> [Romain: merge our two patches together add some option comment disable static libgnutls.a add sngrep autobuilder reference] Signed-off-by: Romain Naour <romain.naour@gmail.com> Tested-by: Bernd Kuhls <bernd.kuhls@t-online.de> [Thomas: do not disable libgnutls.a] Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/libsoup/Config.in')
-rw-r--r--package/libsoup/Config.in4
1 files changed, 4 insertions, 0 deletions
diff --git a/package/libsoup/Config.in b/package/libsoup/Config.in
index bc0ba950aa..236d3c428a 100644
--- a/package/libsoup/Config.in
+++ b/package/libsoup/Config.in
@@ -22,11 +22,15 @@ config BR2_PACKAGE_LIBSOUP_GNOME
config BR2_PACKAGE_LIBSOUP_SSL
bool "https support"
+ depends on !BR2_STATIC_LIBS # gnutls
select BR2_PACKAGE_GLIB_NETWORKING
select BR2_PACKAGE_GNUTLS
help
Enable HTTPS (SSL) support.
+comment "libsoup https support needs a toolchain w/ dynamic library"
+ depends on BR2_STATIC_LIBS
+
endif
comment "libsoup needs a toolchain w/ wchar, threads"