diff options
| author |  Yann E. MORIN <yann.morin.1998@free.fr> | 2017-02-26 12:19:03 +0100 |
|---|---|---|
| committer |  Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2017-02-26 14:31:58 +0100 |
| commit | 779ec7f36dfb85c43c093ec5a19116399bcd3252 (patch) | |
| tree | d83487b103d6e0ee9b5fe03cce86e31e155ed2d1 /package/xfsprogs/xfsprogs.mk | |
| parent | be8177fcea62a3ea1a3c3e870b0da3b600f092ce (diff) | |
| download | buildroot-779ec7f36dfb85c43c093ec5a19116399bcd3252.tar.gz buildroot-779ec7f36dfb85c43c093ec5a19116399bcd3252.tar.bz2 | |
package/xfsprogs: fix static build
xfsprogs links to some libraries from util-linux. Those in turn may use
i18n functions when locales are enabled.
When doing a uClibc build, those i18n functions are provided by the
libintl library from the gettext package.
xfsprogs does not use pkgconfig to find the util-linux libraries, so it
misses the Requires.private field from libblkid, and thus misses the
Libs.private field from libuid.
And so a static link fails because of undefined references to i18n
symbols.
Furthermore, xfsprogs does not use automake; the hand-made Makefiles do
not make use of the LIBS variable set by configure.
We fix that in two ways:
- pass LIBS=-lintl to configure, so that the configure step has a
chance to succeed (as suggested by Waldemar)
- patch a Makefile to link with EXTRALIBS, and pass EXTRALIBS via
XFSPROGS_MAKE_OPTS
Fixes:
http://autobuild.buildroot.org/results/503/50314716a9f72e8bb238e52e9dc342c68f7e0b8b/
http://autobuild.buildroot.org/results/253/253a024698b55dece992b2631e30edf4ff9092f7/
http://autobuild.buildroot.org/results/3fe/3fe0d96cf13af12b0051a95f7865d4e38f4a78af/
http://autobuild.buildroot.org/results/d48/d48e61785d25d33106b7dab1b5cb200cf27d4044/
...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Waldemar Brodkorb <wbx@openadk.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/xfsprogs/xfsprogs.mk')
| -rw-r--r-- | package/xfsprogs/xfsprogs.mk | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/package/xfsprogs/xfsprogs.mk b/package/xfsprogs/xfsprogs.mk index e59f1f6905..c110733c83 100644 --- a/package/xfsprogs/xfsprogs.mk +++ b/package/xfsprogs/xfsprogs.mk @@ -18,6 +18,23 @@ XFSPROGS_CONF_OPTS = \ INSTALL_GROUP=root \ --enable-static +# xfsprogs links some of its programs to libs from util-linux, which use +# i18n functions. For shared-only builds, that's automatically pulled in. +# Static builds need some help, though... +# +# No need to depend on gettext in this case: xfsprogs does not use it for +# itself; util-linux does need it and has it in its own dependencies. +# +# xfsprogs' buildsystem uses hand-made Makefiles, not automake, and they +# do not use the LIBS variable set by configure. So we use EXTRALIBS that +# is added by our patch. +# +# It is not needed to propagate the EXTRALIBS to the install step. +ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS)$(BR2_NEEDS_GETTEXT_IF_LOCALE),yy) +XFSPROGS_CONF_OPTS += LIBS=-lintl +XFSPROGS_MAKE_OPTS = EXTRALIBS=-lintl +endif + XFSPROGS_INSTALL_TARGET_OPTS = DIST_ROOT=$(TARGET_DIR) install $(eval $(autotools-package)) |