path: root/toolchain
diff options
authorGravatar Yann E. MORIN <yann.morin.1998@free.fr>2014-07-31 00:57:15 +0200
committerGravatar Thomas Petazzoni <thomas.petazzoni@free-electrons.com>2014-07-31 23:51:39 +0200
commita930d9cef6bdcf8de7d086ea66d977530200b8e0 (patch)
tree70c8a3bbe98b38d04b22b28c62faa5ffbfd11527 /toolchain
parentc9f5a86eaeb16c76f8b1f9cb940d2207759dd8d3 (diff)
toolchain: linker options with a $ sign are not supported
As reported in bug #7172 [0], setting BR2_TARGET_LDFLAGS to a value containing a $ sign can lead to unexpected results. This is because it is very hard to know when the $ sign gets evaluated: - in the Buildroot-level make - in the shell called by the Buildroot-level make - in the package's own build-system, either at configure time, in the Makefile, in a shell in the Makefile... So, it is very difficult to know how much escaping that would need. A proposal is to use a shell variable to pass such values unmolested. But it is not that simple either, since it still contains a $ sign, and there is not much certainty as to when it would be evaluated. Instead, just document this limitation, both in the help text for BR2_TARGET_LDFLAGS, and in the known-issues section in the manual. Does not really fix #7172, but at least the limitation is documented. [0] https://bugs.buildroot.org/show_bug.cgi?id=7172 Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Mike Zick <minimod@morethan.org> Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'toolchain')
1 files changed, 3 insertions, 0 deletions
diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index 13de9e5c56..2df8ddb637 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -132,6 +132,9 @@ config BR2_TARGET_LDFLAGS
Extra options to pass to the linker when building for the target.
+ Note that options with a '$' sign (eg. -Wl,-rpath='$ORIGIN/../lib')
+ are not supported.
bool "Register toolchain within Eclipse Buildroot plug-in"