summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2017-11-07 17:09:29 (GMT)
committerDenys Vlasenko <vda.linux@googlemail.com>2017-11-08 11:35:02 (GMT)
commitc3797d40a1c57352192c6106cc0f435e7d9c11e8 (patch)
treeab6c18347fe168135382013a660e0725cca52452
parenta5060b8364faa7c677c8950f1315c451403b0660 (diff)
downloadbusybox-c3797d40a1c57352192c6106cc0f435e7d9c11e8.tar.gz
busybox-c3797d40a1c57352192c6106cc0f435e7d9c11e8.tar.bz2
lineedit: do not tab-complete any strings which have control characters
function old new delta add_match 41 68 +27 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--libbb/lineedit.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/libbb/lineedit.c b/libbb/lineedit.c
index c0e35bb..56e8140 100644
--- a/libbb/lineedit.c
+++ b/libbb/lineedit.c
@@ -645,6 +645,18 @@ static void free_tab_completion_data(void)
static void add_match(char *matched)
{
+ unsigned char *p = (unsigned char*)matched;
+ while (*p) {
+ /* ESC attack fix: drop any string with control chars */
+ if (*p < ' '
+ || (!ENABLE_UNICODE_SUPPORT && *p >= 0x7f)
+ || (ENABLE_UNICODE_SUPPORT && *p == 0x7f)
+ ) {
+ free(matched);
+ return;
+ }
+ p++;
+ }
matches = xrealloc_vector(matches, 4, num_matches);
matches[num_matches] = matched;
num_matches++;